Page 2 of 2

Re: Sound issues with BasiliskII-1.0 SDL2 and OSX Catalina

Posted: Sun Feb 07, 2021 1:26 am
by kanjitalk755
RichCini wrote: Sat Feb 06, 2021 1:21 pm If you’d like I can PM you the same code in two source files rather than in-line or I can try to submit on GitHub. Up to you.
If you have any improvements, please make a pull request on GitHub.
RichCini wrote: Sat Feb 06, 2021 1:21 pm Also, I’d like to find a better spot for the chime to sound, like after main window creation. If you can tell me where that is, I can test it. The original spot is after all of what I think are the hardware setups but I think it’s clunky to sound before the main window is open.
The timing to start playing the sound is difficult.
The delay between calling SDL_CreateWindow() and actually displaying it may vary depending on the platform and OS version.

Re: Sound issues with BasiliskII-1.0 SDL2 and OSX Catalina

Posted: Sun Feb 07, 2021 2:04 am
by RichCini
Thanks. Pull requests submitted (hopefully I did it right...first-time Github contributor).

Rich

Re: Sound issues with BasiliskII-1.0 SDL2 and OSX Catalina

Posted: Mon Feb 08, 2021 5:25 pm
by adespoton
kanjitalk755 wrote: Sun Feb 07, 2021 1:26 am
RichCini wrote: Sat Feb 06, 2021 1:21 pm If you’d like I can PM you the same code in two source files rather than in-line or I can try to submit on GitHub. Up to you.
If you have any improvements, please make a pull request on GitHub.
RichCini wrote: Sat Feb 06, 2021 1:21 pm Also, I’d like to find a better spot for the chime to sound, like after main window creation. If you can tell me where that is, I can test it. The original spot is after all of what I think are the hardware setups but I think it’s clunky to sound before the main window is open.
The timing to start playing the sound is difficult.
The delay between calling SDL_CreateWindow() and actually displaying it may vary depending on the platform and OS version.
Seems to me it should be after displaying the window in all cases, but before the System Folder load. This wouldn't be precisely accurate with the original, but would be simpler than patching the ROM to just play the sound without the hardware check.

Re: Sound issues with BasiliskII-1.0 SDL2 and OSX Catalina

Posted: Mon Feb 08, 2021 5:32 pm
by RichCini
@kanjitalk755 placed the code in audio_sdl.cpp and calls it at the end of audio initialization so that it will work with both BII and SS. I have only tried the BII version with the latest pull and it works fine.

Rich